Add MKLocalSearch to the Location pane #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| /// Called if `MKLocalSearchCompleter` encounters an error | ||
| func completer(_ completer: MKLocalSearchCompleter, didFailWithError error: Error) { | ||
| print(error) |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
MKLocalSearchCompleter is an old delegate-based protocol, so I don't think it throws (I could be wrong, I don't spend much time with delegates any more) - it just sends the Error to the didFailWithError function. Suggestions to improve?
There was a problem hiding this comment.
No suggestion, I didn't know about MKLocalSearchCompleter, it was just for know why you did that, thanks.
|
Really great improvement btw thank you ! |
Co-authored-by: Elliot Knight <[email protected]>
|
This is fantastic – thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MKLocalSearchlookups and center the map on the results.latitude, longitude) and center the map on those coordinates.Screen.Recording.2023-11-30.at.01.00.06.mp4